implement error object on multiple exercises #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
sdublish
reviewed
Sep 21, 2018
exercises/say/canonical-data.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "exercise": "say", | |||
| "version": "1.1.0", | |||
| "version": "1.2.0", | |||
| "comments": [ | |||
| "Here -1 is used as expected value to indicate that the", | |||
There was a problem hiding this comment.
Would it make sense to update the comments to reflect the new error object?
There was a problem hiding this comment.
Yes it would. 😄 Thanks for pointing it out.
|
Multiple changes in 1 PR makes reviewing harder. (Note to self: remember to view commits individually.) Make sure you check all the comments at the start of the files. Thanks for taking this on @rpottsoh 👍 |
Sorry about that. I hadn't considered that. |
|
Should I just bust this up into separate PRs? This is getting messy, fast. |
Insti
approved these changes
Sep 24, 2018
As long as nothing else needs to be done it's probably OK, just something to keep in mind for next time. |
sdublish
approved these changes
Sep 24, 2018
rpottsoh
added a commit
that referenced
this pull request
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per #1311
phone-number
say
variable-length-quantity
queen-attack
forth